Repository navigation
fix(sub-header): update sort to use select component and update tests - #3239
Merged
Merged
Conversation
QingyuChai
commented
Feb 7, 2023
|
|
||
| return ( | ||
| <MenuItem | ||
| <SelectMenuItem |
Contributor
Author
There was a problem hiding this comment.
use SelectMenuItem because it's literally MenuItem with isSelectItem
QingyuChai
marked this pull request as ready for review
February 7, 2023 22:38
| .childAt(1) | ||
| .prop('id'), | ||
| ).toBe(messages.dateDESC.id); | ||
| expect(options.at(3).prop('isSelected')).toBe(true); |
Contributor
There was a problem hiding this comment.
Should you check the other options are not selected?
Contributor
Author
There was a problem hiding this comment.
I can make sure that one of them isn't selected, but checking all of them seems a bit redundant
benjamin-shen
previously approved these changes
Feb 7, 2023
benjamin-shen
approved these changes
Feb 7, 2023
QingyuChai
commented
Feb 7, 2023
Comment on lines
+152
to
+154
| options.forEach((option, i) => { | ||
| if (i !== 3) expect(option.prop('isSelected')).toBe(false); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
could have done
options.forEach((option, i) => {
expect(option.prop('isSelected')).toBe(i === 3);
}); but that would have been less readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.