Repository navigation
fix(grid-view): unhide focus outline for grid view slider - #3212
Merged
mergify[bot] merged 2 commits intoJan 12, 2023
Merged
Conversation
QingyuChai
marked this pull request as ready for review
January 12, 2023 22:52
benjamin-shen
approved these changes
Jan 12, 2023
benjamin-shen
left a comment
Contributor
There was a problem hiding this comment.
Not sure why it was hidden in the first place
Interesting, maybe you could check the git blame to see if there was any reason?
Contributor
Author
|
Yeah, not sure why that person added the outline: none |
tjuanitas
approved these changes
Jan 12, 2023
Contributor
looks like the component was originally copied from EUA |
Contributor
Author
|
works as expected on firefox as well - gonna proceed with merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove styles that hide focus outline. Not sure why it was hidden in the first place, it doesn't show up with mouse interaction.
Initially introduced here: ef4a7ee
Before:
https://user-images.githubusercontent.com/24941488/212198025-651b4076-73f3-4000-be5d-c4f9a0baa50f.mov
After:
https://user-images.githubusercontent.com/24941488/212197943-ccb3473d-8f81-426e-9cfb-a094eab9619e.mov