Skip to content

Commit a517b3d

Browse files
fix: stop double-JSON-encoding error fields in Box API errors (box/box-codegen#985) (#1608)
1 parent ad3a8f9 commit a517b3d

2 files changed

Lines changed: 20 additions & 7 deletions

File tree

‎.codegen.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "engineHash": "bcfc85f", "specHash": "88cd5aa", "version": "10.14.0" }
1+
{ "engineHash": "bdc9526", "specHash": "88cd5aa", "version": "10.14.0" }

‎src/networking/boxNetworkClient.ts‎

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
SerializedData,
1818
jsonToSerializedData,
1919
sdIsMap,
20+
sdIsString,
2021
sdToJson,
2122
sdToUrlParams,
2223
} from '../serialization/json';
@@ -436,15 +437,27 @@ export class BoxNetworkClient implements NetworkClient {
436437
errorDescription,
437438
] = sdIsMap(fetchResponse.data)
438439
? [
439-
sdToJson(fetchResponse.data['code']),
440+
sdIsString(fetchResponse.data['code'])
441+
? fetchResponse.data['code']
442+
: undefined,
440443
sdIsMap(fetchResponse.data['context_info'])
441444
? fetchResponse.data['context_info']
442445
: undefined,
443-
sdToJson(fetchResponse.data['request_id']),
444-
sdToJson(fetchResponse.data['help_url']),
445-
sdToJson(fetchResponse.data['message']),
446-
sdToJson(fetchResponse.data['error']),
447-
sdToJson(fetchResponse.data['error_description']),
446+
sdIsString(fetchResponse.data['request_id'])
447+
? fetchResponse.data['request_id']
448+
: undefined,
449+
sdIsString(fetchResponse.data['help_url'])
450+
? fetchResponse.data['help_url']
451+
: undefined,
452+
sdIsString(fetchResponse.data['message'])
453+
? fetchResponse.data['message']
454+
: undefined,
455+
sdIsString(fetchResponse.data['error'])
456+
? fetchResponse.data['error']
457+
: undefined,
458+
sdIsString(fetchResponse.data['error_description'])
459+
? fetchResponse.data['error_description']
460+
: undefined,
448461
]
449462
: [];
450463
if (fetchResponse.status === 0) {

0 commit comments

Comments
 (0)