Skip to content

feat: Support zstd encoding for downloads - #1287

Merged
lukaszsocha2 merged 9 commits into
mainfrom
java-sdk-zstd
Feb 19, 2025
Merged

lukaszsocha2 merged 9 commits into
mainfrom
java-sdk-zstd

Conversation

@congminh1254

@congminh1254 congminh1254 commented Feb 11, 2025 •

Copy link
Copy Markdown
Member

Support use zstd encoding while downloading files.

@congminh1254
congminh1254 marked this pull request as draft February 11, 2025 14:56
@congminh1254
congminh1254 marked this pull request as ready for review February 11, 2025 23:19
@coveralls

coveralls commented Feb 13, 2025 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #4429

Details

  • 34 of 44 (77.27%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 71.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxGlobalSettings.java 2 4 50.0%
src/main/java/com/box/sdk/BoxAPIConnection.java 3 7 42.86%
src/main/java/com/box/sdk/ZstdInterceptor.java 29 33 87.88%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxFileUploadSession.java 1 64.67%
src/main/java/com/box/sdk/EventStream.java 1 86.46%
src/main/java/com/box/sdk/MetadataQuery.java 1 92.59%
Totals Coverage Status
Change from base Build #4411: 0.02%
Covered Lines: 8192
Relevant Lines: 11385

💛 - Coveralls

Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java Outdated
Comment thread src/intTest/java/com/box/sdk/BoxFileIT.java Outdated
Comment thread src/main/java/com/box/sdk/ZstdInterceptor.java Outdated
@lukaszsocha2 lukaszsocha2 changed the title feat: Support zstd encoding feat: Support zstd encoding for downloads Feb 19, 2025

@lukaszsocha2 lukaszsocha2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@congminh1254

Copy link
Copy Markdown
Member Author

It's gtg 🍡

@lukaszsocha2
lukaszsocha2 merged commit 0e3c4c0 into main Feb 19, 2025
@lukaszsocha2
lukaszsocha2 deleted the java-sdk-zstd branch February 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants