X3: parse_rule attribute must always be of rule::attribute_type& - #457
Merged
Merged
Conversation
After boostorg#456 `parse_rule` is always called with value of `rule::attribute_type&` type. By removing attribute type deduction we also will turn any possible bug in `transform_attribute` from a linkage to compile error. Fixes boostorg#454
Kojoley
added a commit
to Kojoley/spirit
that referenced
this pull request
Oct 18, 2019
Regressed in boostorg#457
This was referenced Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #456
parse_ruleis always called with value ofrule::attribute_type&type. By removing attribute type deduction we also will turn any possible bug
in
transform_attributefrom a linkage to compile error.Fixes #454