Skip to content

Fix deprecated MethodSelector API for JUnit Platform 1.10.x-1.12.x compatibility #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
+40 −9
Closed

Fix deprecated MethodSelector API for JUnit Platform 1.10.x-1.12.x compatibility #6999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1a32bf
Initial plan
Copilot Dec 14, 2025
621ec9d
Fix tester to support JUnit Platform 1.13+ by replacing deprecated API
Copilot Dec 14, 2025
74fc99c
Address code review feedback
Copilot Dec 14, 2025
5fcca6c
Update JUnit Jupiter to 5.13.4 and Platform to 1.13.4 to verify fix
Copilot Dec 14, 2025
5b799c5
Fix PreconditionViolationException by avoiding eager method resolution
Copilot Dec 14, 2025
669f538
Revert JUnit Platform to 5.12.2/1.12.2 - 1.13+ has additional archite…
Copilot Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions biz.aQute.tester.junit-platform/bnd.bnd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,11 @@ Bundle-Description: \
# The dependency on aQute packages is only for the
# launcher side. When launched, those dependencies
# are not necessary
# Note about the unusually restricted version range for org.junit.platform - refer
# GitHub issue #6651. The original import package directive is here and can be restored
# if/when #6651 is fixed:
# org.junit.platform.*;version="${range;[==,+);${junit.platform.tester.version}}",\
Import-Package: \
aQute.*;resolution:=optional,\
junit.*;version="${range;[==,5);${junit3.version}}";resolution:=optional,\
org.apache.felix.service.command;resolution:=optional,\
org.junit.platform.*;version="[${junit.platform.tester.version},1.13)",\
org.junit.platform.*;version="${range;[==,+);${junit.platform.tester.version}}",\
org.junit.*;version="${range;[==,+);${junit4.tester.version}}";resolution:=optional,\
*

Expand Down
43 changes: 39 additions & 4 deletions ...ester.junit-platform/src/aQute/tester/bundle/engine/discovery/BundleSelectorResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,25 @@ private BundleSelectorResolver(BundleContext context, EngineDiscoveryRequest req

methodSelectors = request.getSelectorsByType(MethodSelector.class)
.stream()
.map(selector -> DiscoverySelectors.selectMethod(selector.getClassName(), selector.getMethodName(),
selector.getMethodParameterTypes()))
.map(selector -> {
// With JUnit Platform 1.13+, MethodSelector no longer has getMethodParameterTypes().
// We need to detect the API version without calling getJavaMethod() which would
// throw PreconditionViolationException if the method doesn't exist.
// We test for the deprecated method's existence using reflection on the class.
try {
// Check if the deprecated method exists (JUnit Platform < 1.13)
selector.getClass().getMethod("getMethodParameterTypes");
// Older JUnit Platform version, normalize using deprecated method
@SuppressWarnings("deprecation")
String paramTypes = selector.getMethodParameterTypes();
return DiscoverySelectors.selectMethod(selector.getClassName(), selector.getMethodName(),
paramTypes);
} catch (NoSuchMethodException e) {
// JUnit Platform 1.13+: just return the selector as-is
// Don't call getJavaMethod() here as it would throw if method doesn't exist
return selector;
}
})
.collect(toList());

bundleSelectors = request.getSelectorsByType(BundleSelector.class);
Expand Down Expand Up @@ -436,8 +453,26 @@ private static Optional<Method> findMethod(Class<?> clazz, String method, String
}

private static MethodSelector selectMethod(Class<?> testClass, MethodSelector selector) {
return findMethod(testClass, selector.getMethodName(), selector.getMethodParameterTypes())
.map(method -> DiscoverySelectors.selectMethod(testClass, method))
// Detect JUnit Platform version by checking if deprecated method exists
Optional<Method> method;
try {
// Check if the deprecated method exists (JUnit Platform < 1.13)
selector.getClass().getMethod("getMethodParameterTypes");
// Older JUnit Platform version, use deprecated method
@SuppressWarnings("deprecation")
String paramTypes = selector.getMethodParameterTypes();
method = findMethod(testClass, selector.getMethodName(), paramTypes);
} catch (NoSuchMethodException e) {
// JUnit Platform 1.13+: try to get the resolved method
// This may throw PreconditionViolationException if method doesn't exist
try {
method = Optional.ofNullable(selector.getJavaMethod());
} catch (Exception ex) {
// Method doesn't exist or can't be resolved
method = Optional.empty();
}
}
return method.map(m -> DiscoverySelectors.selectMethod(testClass, m))
.orElse(null);
}

Expand Down