Fix uploadError validation rule to work with OS Win. Here the error is string, not integer.

euromark · euromark · commit 1725386c16c1 · 2014-02-12T21:52:18.000+01:00
diff --git a/lib/Cake/Test/Case/Utility/ValidationTest.php b/lib/Cake/Test/Case/Utility/ValidationTest.php
@@ -2368,9 +2368,11 @@ public function testMimeTypeFalse() {
 	public function testUploadError() {
 		$this->assertTrue(Validation::uploadError(0));
 		$this->assertTrue(Validation::uploadError(array('error' => 0)));
+		$this->assertTrue(Validation::uploadError(array('error' => '0')));
 
 		$this->assertFalse(Validation::uploadError(2));
 		$this->assertFalse(Validation::uploadError(array('error' => 2)));
+		$this->assertFalse(Validation::uploadError(array('error' => '2')));
 	}
 
 /**
diff --git a/lib/Cake/Utility/Validation.php b/lib/Cake/Utility/Validation.php
@@ -964,7 +964,7 @@ public static function uploadError($check) {
 			$check = $check['error'];
 		}
 
-		return $check === UPLOAD_ERR_OK;
+		return (int)$check === UPLOAD_ERR_OK;
 	}
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ public static function uploadError($check) {`
`964`	`964`	`$check = $check['error'];`
`965`	`965`	`}`
`966`	`966`
`967`		`- return $check === UPLOAD_ERR_OK;`
	`967`	`+ return (int)$check === UPLOAD_ERR_OK;`
`968`	`968`	`}`
`969`	`969`
`970`	`970`	`/**`