fix: disable idempotency doesn't disable dynamodb client creation in persistent store#796
Merged
pankajagrawal16 merged 2 commits intoaws-powertools:masterfrom Mar 18, 2022
Conversation
msailes
approved these changes
Mar 16, 2022
Contributor
msailes
left a comment
There was a problem hiding this comment.
this will help with testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When disabling idempotency using the environment variable "
POWERTOOLS_IDEMPOTENCY_DISABLED", the creation of theDynamoDbClientwas not disabled, which is not desired when performing tests (it tries to connect to AWS or requires to setup a local dynamodb)Description of changes:
When using the "
POWERTOOLS_IDEMPOTENCY_DISABLED" env var, theDynamoDbClient(for the idempotency module) is not created.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.