Merged
Conversation
e91c63a to
a6370c8
Compare
Contributor
💾 Artifacts Size Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1571 +/- ##
=========================================
Coverage 89.79% 89.79%
Complexity 406 406
=========================================
Files 44 44
Lines 1274 1274
Branches 165 165
=========================================
Hits 1144 1144
Misses 88 88
Partials 42 42 ☔ View full report in Codecov by Sentry. |
jeromevdl
previously approved these changes
Feb 22, 2024
Contributor
|
e2e are still failing here... |
a6370c8 to
3bc8cd4
Compare
scottgerring
commented
Feb 22, 2024
| </aspectLibrary> | ||
| <aspectLibrary> | ||
| <groupId>software.amazon.lambda</groupId> | ||
| <artifactId>powertools-idempotency-dynamodb</artifactId> |
Contributor
Author
There was a problem hiding this comment.
The aspect is in core, not DDB
scottgerring
commented
Feb 22, 2024
| <dependency> | ||
| <groupId>software.amazon.lambda</groupId> | ||
| <artifactId>powertools-idempotency</artifactId> | ||
| <artifactId>powertools-idempotency-dynamodb</artifactId> |
Contributor
Author
There was a problem hiding this comment.
This was breaking tests
scottgerring
commented
Feb 22, 2024
| <aspectLibrary> | ||
| <groupId>software.amazon.lambda</groupId> | ||
| <artifactId>powertools-idempotency</artifactId> | ||
| <artifactId>powertools-idempotency-core</artifactId> |
Contributor
Author
There was a problem hiding this comment.
this was breaking tests
scottgerring
commented
Feb 22, 2024
| import software.amazon.lambda.powertools.idempotency.IdempotencyConfig; | ||
| import software.amazon.lambda.powertools.idempotency.Idempotent; | ||
| import software.amazon.lambda.powertools.idempotency.persistence.DynamoDBPersistenceStore; | ||
| import software.amazon.lambda.powertools.idempotency.persistence.dynamodb.DynamoDBPersistenceStore; |
Contributor
Author
There was a problem hiding this comment.
This was breaking tests
scottgerring
commented
Feb 22, 2024
| <dependency> | ||
| <groupId>software.amazon.lambda</groupId> | ||
| <artifactId>powertools-idempotency</artifactId> | ||
| <artifactId>powertools-idempotency-dynamodb</artifactId> |
Contributor
Author
There was a problem hiding this comment.
This was breaking tests
scottgerring
commented
Feb 22, 2024
| <aspectLibrary> | ||
| <groupId>software.amazon.lambda</groupId> | ||
| <artifactId>powertools-idempotency</artifactId> | ||
| <artifactId>powertools-idempotency-core</artifactId> |
Contributor
Author
There was a problem hiding this comment.
The aspect is in core, not DDB
Contributor
Author
|
@jeromevdl it lives 💪 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1562
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.