feat: integration with CloudWatch ServiceLens #88#111
Merged
pankajagrawal16 merged 2 commits intomasterfrom Sep 25, 2020
Merged
feat: integration with CloudWatch ServiceLens #88#111pankajagrawal16 merged 2 commits intomasterfrom
pankajagrawal16 merged 2 commits intomasterfrom
Conversation
Contributor
pankajagrawal16
left a comment
There was a problem hiding this comment.
Looks neat. Few suggestions.
...-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/SystemWrapper.java
Outdated
Show resolved
Hide resolved
...rc/test/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspectTest.java
Show resolved
Hide resolved
msailes
reviewed
Sep 25, 2020
...rc/test/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspectTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also please update commit and pr title to match semantics before merge 🙂 |
...ng/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java
Outdated
Show resolved
Hide resolved
cleanup on last pr #111
pankajagrawal16
approved these changes
Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Closes #88
Integration with CloudWatch ServiceLens:
The xray_trace_id key is added to log output when tracing is active. This enables the log correlation functionality in ServiceLens to work with applications using powertools.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.