Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a native filter will mark filters as out of scope even though they aren't #32014

Open
2 of 3 tasks
geido opened this issue Jan 28, 2025 · 4 comments
Open
2 of 3 tasks
Labels
dashboard:native-filters Related to the native filters of the Dashboard preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@geido
Copy link
Member

geido commented Jan 28, 2025

Bug description

Repro steps

  • Go to the video games dashboard
  • Edit the Genre filter by saying sort value filters by count
  • Save the filter
  • Edit the filter again and uncheck filter values and save

Actual results

When we weren't sorted all filters were in scope, after we sorted filters are still in scope, however, when you uncheck sort filters are now out of scope

Workaround

Moving away from the Dashboard and coming back will fix the problem

Screenshots/recordings

Screen.Recording.2024-12-20.at.12.55.37.PM.mov

Superset version

master / latest-dev

Python version

3.9

Node version

18 or greater

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Jan 28, 2025
@LevisNgigi
Copy link
Contributor

Currently investigating the issue.

@geido
Copy link
Member Author

geido commented Jan 30, 2025


🎉 Preset Bounty Available: $250 USD 🎉

To claim this bounty, please carefully follow the steps below.


📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1055


💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. labels Jan 30, 2025
@LevisNgigi
Copy link
Contributor

Hey I would love to work on this?

@fardin-developer
Copy link
Contributor

@geido, if you assign me this issue, I'll fix it and submit a PR at the earliest. Looking forward to contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Development

No branches or pull requests

4 participants
@geido @fardin-developer @LevisNgigi and others