refactor(Dropdown): Migrate Dropdown to Ant Design 5 #31972
+538
−776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
27c2069 to
5bb1d2c
Compare
|
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/e2e/explore/chart.test.js
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Jan 30, 2025
| @@ -67,7 +67,7 @@ const decideType = (buttonStyle: ButtonStyle) => { | |||
| success: 'primary', | |||
| secondary: 'default', | |||
| default: 'default', | |||
| tertiary: 'dashed', | |||
| tertiary: 'default', | |||
There was a problem hiding this comment.
Is this change related to the Dropdown? Looks like it can potentially affect other components?
There was a problem hiding this comment.
I think this was an oversight on button pr. I think it's supposed to be default.
kgabryje
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate Dropdown to Ant Design 5
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Check for visual changes manually
ADDITIONAL INFORMATION