add new decomission action

Author: harshavardhana

env/env.go

@@ -55,8 +55,8 @@ func SetEnvOn() {
 
 // IsSet returns if the given env key is set.
 func IsSet(key string) bool {
-	_, _, _, ok := LookupEnv(key)
-	return ok
+	_, _, _, err := LookupEnv(key)
+	return err == nil
 }
 
 // Get retrieves the value of the environment variable named
@@ -70,7 +70,7 @@ func Get(key, defaultValue string) string {
 	if ok {
 		return defaultValue
 	}
-	if v, _, _, ok := LookupEnv(key); ok {
+	if v, _, _, err := LookupEnv(key); err == nil {
 		return v
 	}
 	return defaultValue

env/web_env.go

@@ -175,7 +175,7 @@ func Environ() []string {
 // Additionally if the input is env://username:password@remote:port/
 // to fetch ENV values for the env value from a remote server.
 // In this case, it also returns the credentials username and password
-func LookupEnv(key string) (string, string, string, bool) {
+func LookupEnv(key string) (string, string, string, error) {
 	v, ok := os.LookupEnv(key)
 	if ok && strings.HasPrefix(v, webEnvScheme) {
 		// If env value starts with `env*://`
@@ -186,15 +186,16 @@ func LookupEnv(key string) (string, string, string, bool) {
 			env, eok := os.LookupEnv("_" + key)
 			if eok {
 				// fallback to cached value if-any.
-				return env, user, pwd, eok
+				return env, user, pwd, nil
 			}
+			return env, user, pwd, err
 		}
 		// Set the ENV value to _env value,
 		// this value is a fallback in-case of
 		// server restarts when webhook server
 		// is down.
 		os.Setenv("_"+key, v)
-		return v, user, pwd, true
+		return v, user, pwd, nil
 	}
-	return v, "", "", ok
+	return v, "", "", nil
 }

iam/policy/admin-action.go

@@ -28,6 +28,9 @@ const (
 	// HealAdminAction - allows heal command
 	HealAdminAction = "admin:Heal"
 
+	// DecomissionAdminAction - allows decomissioning of pools
+	DecomissionAdminAction = "admin:Decomission"
+
 	// Service Actions
 
 	// StorageInfoAdminAction - allow listing server info