pkg/env: IsSet returns true if EnvKey has a value

Author: harshavardhana

env/env.go

@@ -55,8 +55,7 @@ func SetEnvOn() {
 
 // IsSet returns if the given env key is set.
 func IsSet(key string) bool {
-	_, _, _, err := LookupEnv(key)
-	return err == nil
+	return Get(key, "") != ""
 }
 
 // Get retrieves the value of the environment variable named

env/web_env_test.go env/env_test.goenv/web_env_test.go renamed to env/env_test.go

@@ -89,6 +89,20 @@ func TestWebEnv(t *testing.T) {
 	}
 }
 
+func TestIsSet(t *testing.T) {
+	os.Setenv("_TEST_ENV", "")
+	defer os.Unsetenv("_TEST_ENV")
+
+	if IsSet("_TEST_ENV") {
+		t.Fatal("Expected IsSet(false) but found IsSet(true)")
+	}
+
+	os.Setenv("_TEST_ENV", "v")
+	if !IsSet("_TEST_ENV") {
+		t.Fatal("Expected IsSet(true) but found IsSet(false)")
+	}
+}
+
 func TestGetEnv(t *testing.T) {
 	// Set empty env-value, this test covers situation
 	// where env is set but with empty value, choose