Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Sweeper: should allow configuring pod states to sweep #10349

Open
prein opened this issue Feb 15, 2022 · 0 comments
Open

Pod Sweeper: should allow configuring pod states to sweep #10349

prein opened this issue Feb 15, 2022 · 0 comments
Assignees

Comments

@prein
Copy link

prein commented Feb 15, 2022

Tell us about the problem you're trying to solve

While trying to understand why pod sweeper doesn't work for us at the moment, I tried running the kubectl command found in get_worker_pods in https://github.com/airbytehq/airbyte/blob/master/kube/resources/pod-sweeper.yaml#L10 and noticed that it returns pods in any phase other than Running including pods in Pending phase. Then in

if [ "$POD_STATUS" = "Succeeded" ]; then
Succeeded status is handled differently from other statuses.
I would like to have only the pods in phases Failed and Succeeded to be garbage collected.

Describe the solution you’d like

A variable with list of phase names maybe and if not in the list then ignore? Or a var to toggle Pending pods deletion.

Are you willing to submit a PR?

Sure

@prein prein added needs-triage type/enhancement New feature or request labels Feb 15, 2022
@marcosmarxm marcosmarxm added kubernetes area/platform issues related to the platform and removed needs-triage labels Feb 22, 2022
@marcosmarxm marcosmarxm changed the title Pod sweeper should allow configuring pod states to sweep Pod Sweeper: should allow configuring pod states to sweep Nov 30, 2022
@bleonard bleonard added the frozen Not being actively worked on label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants