Empty directories are duplicated when deleted and added again

[amosavian]

When I delete a file a folder, then add a file with same name, I got duplicated entries with same name.

[abbeycode]

Thanks for reporting this. Can you please take a look at the issue template I created and copy/paste into your issue? I could use the additional info requested there to figure out what's going on for you. I'm going to paste this into Issue #56 also.

[amosavian]

Steps to reproduce:
1- Add a file to zip with writeData:filePath:progress:error:
2- Delete file using deleteFile:error:
3- Readd same file using step 1
4- List files using listFileInfo:
Result of step 4 contains file 2 times.

I can send testflight invitation of my app to check in beta version

[abbeycode]

I've pushed a test case into a branch that follows the code you described, but with correct results. Can you please update the test case so it fails in the way you're expecting?

[amosavian]

Weird because I got it fixed now! or I may don't remember exact steps.
Thanks

[amosavian]

Finally I found the problem.
1- create an empty folder, not file, using the code I made a pull request.
2- delete that folder
3- create an empty folder with same name again

I think the problem occurs when data is empty, instance of [NSData data].

[abbeycode]

Is this something you're still working on?

[abbeycode]

@amosavian I'm going through open issues now, so you'll see me replying to a bunch of them. Sorry to hit you all at once :)

Are you still taking a look at this, or should I close it out?

[amosavian]

This problem still exists. This only occurs when I create folder in zip, not a regular file.

[abbeycode]

So steps to reproduce are the following?

1. In an archive add an empty directory (use [NSData data])
2. Delete the directory created
3. Create that directory again

And then what happens at that point? Is an NSError returned?

[amosavian]

No, when I list archive files at then end, I get entry twice. Indeed deleted directory revives somehow.

[abbeycode]

I created a test case again (this time it happens to be in Swift because the file with other writeData tests is in Swift. The test case is passing for me. Can you take a look again and see if we can modify it so it demonstrates your issue?