CampTix: Add missing property declarations to CampTix_Plugin#1703
Merged
dd32 merged 2 commits intoproductionfrom Apr 22, 2026
Merged
CampTix: Add missing property declarations to CampTix_Plugin#1703dd32 merged 2 commits intoproductionfrom
dd32 merged 2 commits intoproductionfrom
Conversation
Declare `shortcode_str`, `order`, `tickets_url`, `flush_tickets_page`, and `removed_shortcodes` as protected properties on the class. These were being used throughout the plugin but never formally declared, which triggers deprecation notices on PHP 8.2+. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CampTix plugin to avoid PHP 8.2+ dynamic property deprecation notices by formally declaring several previously-implicit instance properties on CampTix_Plugin.
Changes:
- Declares
shortcode_str,order,tickets_url,flush_tickets_page, andremoved_shortcodesas class properties. - Initializes
removed_shortcodesto an empty array by default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Claude 8, CoPilot 1. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses PHP 8.2+ dynamic property deprecation notices in the CampTix plugin by formally declaring several previously-implicit instance properties on CampTix_Plugin.
Changes:
- Declare missing properties on
CampTix_Plugin:shortcode_str,order,tickets_url,flush_tickets_page, andremoved_shortcodes. - Initialize
removed_shortcodesto an empty array to match existing usage patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protected $order; | ||
| protected $tickets_url; | ||
| protected $flush_tickets_page; | ||
| public $removed_shortcodes = array(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shortcode_str,order,tickets_url,flush_tickets_page, andremoved_shortcodesasprotectedproperties onCampTix_Plugin.protectedis the correct visibility — no external code or subclass accesses these properties.Test plan
🤖 Generated with Claude Code