Skip to content

test: keep the admin bar's first-post-room test from depending on the clock - #886

Merged
josephfusco merged 2 commits into
mainfrom
test/admin-bar-room-order
Oct 23, 2026
Merged

josephfusco merged 2 commits into
mainfrom
test/admin-bar-room-order

Conversation

@josephfusco

Copy link
Copy Markdown
Collaborator

This failed #870's multisite run because two writes straddled a second boundary and the admin bar reads rows newest first.

Related: #870

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with finding the flaky test's cause.

@josephfusco josephfusco added [Type] Bug An existing feature is broken [Area] Infrastructure Issues for the repository infrastructure php Pull requests that update php code labels Oct 23, 2026
@josephfusco
josephfusco marked this pull request as ready for review October 23, 2026 14:57
@josephfusco
josephfusco merged commit 8492a26 into main Oct 23, 2026
25 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@josephfusco
josephfusco deleted the test/admin-bar-room-order branch October 23, 2026 14:57
@github-actions github-actions Bot added this to the 0.18.4 milestone Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Infrastructure Issues for the repository infrastructure php Pull requests that update php code [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant