Repository navigation
Introduce plugins folder for standalone plugins - #948
Merged
Merged
Conversation
mukeshpanchal27
commented
Jan 18, 2024
mukeshpanchal27
marked this pull request as ready for review
January 18, 2024 08:36
swissspidy
reviewed
Jan 18, 2024
swissspidy
reviewed
Jan 18, 2024
swissspidy
reviewed
Jan 18, 2024
swissspidy
reviewed
Jan 18, 2024
Co-authored-by: Pascal Birchler <pascalb@google.com>
felixarntz
approved these changes
Jan 18, 2024
felixarntz
left a comment
Member
There was a problem hiding this comment.
This looks great to me, considering the current requirements on #934. Once you've removed the temporary changes, I think we can merge this.
We may want to keep the issue open though to work in a separate PR on the unit testing setup, to allow for it to test individual plugins as well as Performance Lab, e.g. via distinct test suites (see #934 (comment)).
To test that, we can temporarily move one of the built modules into plugins, though that part should be reverted before merge since we should not remove the modules until 3.0.0.
swissspidy
approved these changes
Jan 19, 2024
felixarntz
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #934
Relevant technical choices
I have added some TODO for testing purpose once the PR is ready for merge we will remove those TODOs.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.