Repository navigation
Extensions: Remove the Code Editor extension - #1048
Merged
Merged
Conversation
The Code Editor lives in AllTerrainDeveloper/desktop-mode-official-extensions, so drop the bundled copy and the docs, packaging and lint references that pointed at it. The README now points at that repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Removes the bundled Code Editor extension (
extensions/desktop-mode-code-editor/). The README now points to desktop-mode-official-extensions, where the extension also lives.Nothing in the core plugin loads it, and CI never built or tested it.
Rationale
The Code Editor is an optional sibling plugin, and it already has a home in the official-extensions repository. Keeping a second copy here means two copies drifting apart.
The copy in the official-extensions repo is brought up to date in AllTerrainDeveloper/desktop-mode-official-extensions#3.
Implementation
extensions/desktop-mode-code-editor/anddocs/examples/code-editor-open.md, and removes the links to that example and theos-code-openrow indocs/api-index.md, since core never handled that message.docs/javascript-reference.mdstill useswpdc-editorin itsopenWindowexample, now linking to the official-extensions repo.docs/hooks-reference.md,docs/RELEASE.md,bin/extract-i18n.shand a comment inbin/package-extensions.sh.wpdcprefix from thephpcs.xml.distallowlist. phpcs already excluded/extensions/and no core PHP uses the prefix.Left as is: the
wpDesktopNativeWindowscompatibility bag insrc/native-windows.ts, which external copies of the extension still write to, andwpdc-editoras an example id in theWindow.send/Window.ondocs.Stacked under #1049, which removes the Cron Manager the same way.
Testing instructions
The first four scripts passed locally (
test:js: 543 files, 6,899 tests).lint:phpneeds its wp-env container, so phpcs-nran directly over the same tree instead and was clean../bin/package-extensions.shshould now produce one zip per remaining extension, with nodesktop-mode-code-editor.zip.