Repository navigation
Conversation
The build job in build-plugin-zip.yml was exposing job.status as a custom output to communicate success/failure to downstream jobs. GitHub Actions natively provides this through needs.<job_id>.result, which is simpler and avoids introducing a custom output that could mask the native context or introduce bugs. Fixes WordPress#78203 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Gilmoursa! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Could a maintainer please add the |
desrosj
left a comment
There was a problem hiding this comment.
Thanks for this, @Gilmoursa! This looks good, but I am going to close this out as a duplicate of #78208 as that PR was opened first and the 2 are identical.
But don't worry, you'll still receive props!
|
Duplicage of #78208. |
What?
Fixes #78203
Removes the custom
job_statusoutput from thebuildjob inbuild-plugin-zip.ymland replaces its two downstream usages with the native GitHub Actionsneeds.<job_id>.resultcontext.Why?
GitHub Actions natively exposes job success/failure status through
needs.<job_id>.result. Using a custom output to re-exposejob.statusis redundant, adds unnecessary indirection, and could introduce subtle bugs or security issues if the pattern spreads.How?
outputs: job_status: ${{ job.status }}from thebuildjobneeds.build.outputs.job_status == 'success'withneeds.build.result == 'success'inpublish-to-container-registryneeds.build.outputs.job_status == 'failure'withneeds.build.result == 'failure'inrevert-version-bumpBehavior is identical — this is a pure refactor with no functional change.