Skip to content

Make it easier to align the Navigation Overlay Close button - #76290

Open
rohitmathur-7 wants to merge 5 commits into
WordPress:trunkfrom
rohitmathur-7:feature/align-navigation-overlay-close-button
Open

rohitmathur-7 wants to merge 5 commits into
WordPress:trunkfrom
rohitmathur-7:feature/align-navigation-overlay-close-button

Conversation

@rohitmathur-7

Copy link
Copy Markdown
Contributor

What?

Closes #75662

Why?

Make it easier to align the Navigation Overlay Close button

How?

Added Block support for alignment

Testing Instructions

  • Open a page.
  • Add a Navigation block.
  • In the Navigation block settings edit a Overlay Template.
  • Move the Navigation Overlay Close button outside of Row and we can see the alignment options in the toolbar.

Screenshots or screencast

Screenshot at Mar 08 10-32-51

@github-actions github-actions Bot added the [Package] Block library /packages/block-library label Mar 8, 2026
@github-actions

github-actions Bot commented Mar 8, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rohitmathur-7 <rohitmathur7@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan

Copy link
Copy Markdown
Contributor

Hi @rohitmathur-7 The block support documentation needs to be updated; you can find the commands you need to run in the error message (npm run docs:build)

@carolinan

Copy link
Copy Markdown
Contributor

Hi @rohitmathur-7 Are you available and able to update the pull request?

@rohitmathur-7

Copy link
Copy Markdown
Contributor Author

Hi @carolinan ,
Yes I will update it.
Sorry for the delay. 🙇🏻

@rohitmathur-7
rohitmathur-7 requested review from a team and juanmaguitar as code owners June 4, 2026 07:00
@github-actions github-actions Bot added the [Package] Components /packages/components label Jun 4, 2026
@rohitmathur-7

Copy link
Copy Markdown
Contributor Author

Hii @carolinan ,
Updated the docs by running npm run docs:build command.

@ciampo ciampo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in @wordpress/components seem unreleated and should be undone, likely caused by a mismatch in the version of typescript installed locally vs the one expected in the project

This reverts commit 0e3bb45.
@github-actions github-actions Bot removed the [Package] Components /packages/components label Jun 11, 2026
@rohitmathur-7

Copy link
Copy Markdown
Contributor Author

The changes in @wordpress/components seem unreleated and should be undone, likely caused by a mismatch in the version of typescript installed locally vs the one expected in the project

@ciampo Have reverted the changes in @wordpress/components.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Navigation Overlays [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it easier to align the Navigation Overlay Close button

3 participants