bugfixes and more elaborate close callbacks #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, onWebsocketClosing, onWebsocketClose to give the user more insights/control over the different steps during the close handshake. This is especially necessary because of the asynchronous nature of the implementation.
…ck). Instead of a java.nio.channels.NotYetConnectedException a new org.java_websocket.exceptions.WebsocketNotConnectedException will be thrown. Formatted code and started to renaming the inexpressive conn variables. The state getter methods still have to be touched.
… return null when connection is closed.
…stead of shouting down the client/server (TooTallNate#122)
…d the currently connected websockets. (TooTallNate#138) Also removed the setAddress method since it is misleading and unnecessary.
…r own callback onWebsocketMessageFragment
Davidiusdadi
added a commit
that referenced
this pull request
Dec 11, 2012
bugfixes and more elaborate close callbacks and added onMessageFragment callback
maakolk
pushed a commit
to maakolk/Java-WebSocket
that referenced
this pull request
Mar 5, 2017
bugfixes and more elaborate close callbacks and added onMessageFragment callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more tests still have to be done.