Draft_75 long messages (+suggested patch)

[lassic]

Hi,
I'm using this library on Android to communicate with an (old?) Draft_75 server.
I found that long messages from the server were not assembled correctly on the client side.
I'm not a big expert on web sockets, so I'm not even sure Draft_75 is supposed to handle this on the client or how.
Could be a crude hack, but what I ended up doing to get it working was:

// Changes to Draft_75 class

1. add a boolean field:
   private boolean appending = false;
2. inside if (readingState) { ... }
   curframe.setOptcode ( Opcode.CONTINIOUS ); // instead of TEXT
   this.appending = true;
3. when closing the read on END_OF_FRAME:
   curframe.setOptcode ( this.appending ? Opcode.CONTINIOUS : Opcode.TEXT );
   this.appending = false;

This makes WebSocket enter the Opcode.CONTINIOUS state when reading such frames,
and when the fin is marked on the last frame part, the message is emitted.

Sorry if this is way off or something, hopefully it will help somehow.

[Davidiusdadi]

Thanks you very much for finding that bug!
Draft_75 is old and most (all?) current browsers do not support it (any more).

[lassic]

Happy to contribute, thanks for the code and effort on this lib, it seems like one of the better choices for Android currently. :)

I'm actually using this in a non-browser client right now (browsers will join later), and will probably update the server when I can (what's the current popular draft btw?)

[Davidiusdadi]

The drafts are named after http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17.

Succeeding drafts are often "binary compatible" so the our implemented drafts should cover the most important features of all specified drafts. Currently there are a lot of small gaps like the handling of damaged UTF8 text messages and some ping and pong edge cases. Also not yet supported are wss and protocol extension capabilities.

But Draft10 and 17 should have full framing support.

BTW: If you do not specify any draft in the constructor of the server it will auto detect the clients draft.

@lassic Could you take a look at #60?

[lassic]

Thanks for the detailed explanation.

For now I don't require wss so it's fine (I read on another project that supporting wss with NIO can be a bit of a pain, but I haven't looked into it).
Also, I'm only using the client side for now, but I'll keep updating my experience on the client for Android on the issue you asked.