Repository navigation
rename files to use a .tentative.html convention since they correspond with a proposed HTML feature - #2
Merged
Conversation
…d with a proposed HTML feature
|
|
|
LGTM |
scottjehl
pushed a commit
that referenced
this pull request
Mar 10, 2026
Make reporting of sourceFile, lineNumber, column more consistent Changes the test so that it checks for nulls. Added test (#2) that has script running and therefore should have source information. /content-security-policy/reporting-api/report-to-directive-allowed-in-meta.https.sub.html also had the same problem, of expecting source code information with no running javascript. Checks for null instead. See https://w3c.github.io/webappsec-csp/#create-violation-for-global Differential Revision: https://phabricator.services.mozilla.com/D278839 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1909705 gecko-commit: cdb2d306e3f6e3c8e23075b67592682a91e8fcdb gecko-reviewers: dom-core, smaug
scottjehl
pushed a commit
that referenced
this pull request
Mar 23, 2026
…s#58514) To "prepare the script element" [1] exits early when the element is disconnected. In this test, the script element represented by frag_script_2 which logs "inline script #3" is disconnected in the preceeding script (frag_script_1 / "inline script #2"). Since post-connection steps [2] are executed in the tree order, by the time we are to "prepare the script element" on frag_script_2 / "inline script #3", the script element is already disconnected and the script will not be executed. This test failing in Chrome and Safari but passing in Firefox. After the change, the test passes in Chrome and Safari and fails in Firefox. [1] https://html.spec.whatwg.org/multipage/scripting.html#prepare-the-script-element [2] https://dom.spec.whatwg.org/#concept-node-post-connection-ext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.