Skip to content

Conversation

@emmacadence
Copy link
Contributor

The previous code would fail to parse a password from a connection string if the password was empty. This uses the code used in, e.g., https://github.com/RichardKnop/machinery/blob/master/v1/brokers/redis/goredis.go#L43, as well as the backend.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #656 (2b9005f) into master (0d5824a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   37.41%   37.41%           
=======================================
  Files          36       36           
  Lines        3122     3122           
=======================================
  Hits         1168     1168           
  Misses       1806     1806           
  Partials      148      148           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5824a...2b9005f. Read the comment docs.

@RichardKnop
Copy link
Owner

👍

@RichardKnop RichardKnop merged commit 37c6ee5 into RichardKnop:master Feb 11, 2021
@emmacadence emmacadence deleted the redis-lock-parsing branch February 22, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants