Push already popped messages back into queue during graceful termination #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 39.38% 39.38%
=======================================
Files 32 32
Lines 3344 3344
=======================================
Hits 1317 1317
Misses 1885 1885
Partials 142 142 Continue to review full report at Codecov.
|
shivanshgaur
commented
Jul 10, 2020
| close(deliveries) | ||
| return | ||
| case <-pool: | ||
| select { |
Contributor
Author
There was a problem hiding this comment.
Added to prevent any further message pops
Contributor
Author
|
@RichardKnop Can we create a release with this? |
Owner
|
Sure will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Redis broker pops
concurrency+2extra messages from the queue and keeps it in memory while processing previous messages. Now if the worker process shuts down abruptly during the processing due to unforeseen circumstances, thenconcurrency+2messages are lost forever.Also, during graceful termination, the already popped messages are first processed and only then the worker shuts down. This leads to higher time for graceful terminations and one has to set the graceful termination timeout period to a higher value.
This PR makes changes to enqueue those messages back into the queue once a termination signal is received. This will bring down the time for graceful termination considerably.