Skip to content

Conversation

@gow
Copy link
Contributor

@gow gow commented May 19, 2020

The redis broker sometimes shuts down before currently processing tasks are complete. This typically is not an issue except when these running tasks wish to publish other tasks before completing. Since the StopConsuming() method closes the Redis pool, publishing of new tasks fail as well.

This PR waits for the tasks currently being processed before closing the redis pool.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #552 into master will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   38.15%   39.19%   +1.03%     
==========================================
  Files          32       32              
  Lines        3310     3345      +35     
==========================================
+ Hits         1263     1311      +48     
+ Misses       1908     1892      -16     
- Partials      139      142       +3     
Impacted Files Coverage Δ
v1/backends/redis/redis.go 69.39% <0.00%> (-0.55%) ⬇️
v1/worker.go 3.39% <0.00%> (-0.18%) ⬇️
v2/worker.go 3.39% <0.00%> (+1.30%) ⬆️
v2/server.go 26.89% <0.00%> (+26.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c15ac0...fc8fc17. Read the comment docs.

@RichardKnop RichardKnop merged commit c9512ae into RichardKnop:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants