Skip to content

Conversation

@bharat-p
Copy link
Contributor

@bharat-p bharat-p commented Jul 3, 2019

Fixes #433

When using SQS broker there is no way to get hold of SQS message's ReceiptHandle, this PR adds a new property SQSReceiptHandle to tasks.Signature which gets populated by SQS broker when consuming a message

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4c148cb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #434   +/-   ##
=========================================
  Coverage          ?   47.93%           
=========================================
  Files             ?       29           
  Lines             ?     2643           
  Branches          ?        0           
=========================================
  Hits              ?     1267           
  Misses            ?     1237           
  Partials          ?      139
Impacted Files Coverage Δ
v1/tasks/signature.go 41.17% <ø> (ø)
v1/brokers/sqs/sqs.go 51.36% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c148cb...d2624f7. Read the comment docs.

@bharat-p
Copy link
Contributor Author

bharat-p commented Jul 3, 2019

@RichardKnop after merging this PR, please also tag new version so it can be referenced by go.mod

@bharat-p
Copy link
Contributor Author

bharat-p commented Jul 6, 2019

@RichardKnop can you please merge this

@RichardKnop RichardKnop merged commit 7022984 into RichardKnop:master Jul 12, 2019
@bharat-p bharat-p deleted the 433-expose-sqs-receipt-handle branch July 28, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose SQS message ReceiptHandle in task.Signature

2 participants