data.table 1.15.0 two failing tests on CRAN

[TysonStanley]

CRAN contacted me today with what looks like two failing tests.

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_data.table.html.
Please correct before 2024-02-27 to safely retain your package on CRAN.

Note that this will be the final reminder.

The CRAN Team

[TysonStanley]

These look like ones that normally fix themselves with a re-run of the build but could be wrong.

[tdhock]

I think he means the M1mac issue,

* checking whether package ‘data.table’ can be installed ... [11s/12s] WARNING
Found the following significant warnings:
  fwriteR.c:267:108: warning: format specifies type 'long long' but the argument has type 'R_xlen_t' (aka 'long') [-Wformat]
See ‘/Users/ripley/R/packages/tests-devel/data.table.Rcheck/00install.out’ for details.

[TysonStanley]

Yeah, you are probably right although they didn't enforce it a few weeks ago when we submitted 1.15.0.

Looks like it was fixed in #5929 so we just need to merge 1.15.0 to master and merge that pull request and I can start getting a patch ready.

[TysonStanley]

Do we have a branch we are using to create the patch 1.15.2?

[jangorecki]

Not yet. Create it branching from 1.15.0 branch.

[MichaelChirico]

https://github.com/Rdatatable/data.table/tree/patch-1.15.2

[TysonStanley]

1.15.2 has been submitted to CRAN. Will update once I hear back from them.

[MichaelChirico]

I see it's been accepted. Thanks @TysonStanley! What do we need to do now on master? Just add the exact dates & NEWS items?

The release procedure looks off, I think because we are always submitting .{2,4,6,8,...} patch releases from branches:

data.table/.dev/CRAN_Release.cmd

Lines 636 to 647 in 07fd933

	###### Bump dev for PATCH RELEASE
	## WARNING: review this process during the next first patch release (x.y.2) from a regular release (x.y.0), possibly during 1.15.2 release.
	# 0. Close milestone to prevent new issues being tagged with it. The final 'release checks' issue can be left open in a closed milestone.
	# 1. Check that 'git status' shows 4 files in modified and uncommitted state: DESCRIPTION, NEWS.md, init.c and this .dev/CRAN_Release.cmd
	# 2. Bump patch version in DESCRIPTION to next odd number. Note that DESCRIPTION was in edited and uncommitted state so even number never appears in git.
	# 3. Add new heading in NEWS for the next dev PATCH version. Add "(submitted to CRAN on <today>)" on the released heading.
	# 4. Bump patch version in dllVersion() in init.c
	# 5. Bump 3 patch version numbers in Makefile
	# 6. Search and replace this .dev/CRAN_Release.cmd to update 1.14.99 to 1.15.99
	# 7. Another final gd to view all diffs using meld. (I have `alias gd='git difftool &> /dev/null'` and difftool meld: http://meldmerge.org/)
	# 8. Push to master with this consistent commit message: "1.15.0 on CRAN. Bump to 1.15.99"
	# 9. Take sha from step 8 and run `git tag 1.14.8 96c..sha..d77` then `git push origin 1.14.8` (not `git push --tags` according to https://stackoverflow.com/a/5195913/403310)

We should still push the tag, but most of those steps seem irrelevant to me.

[TysonStanley]

Yes, will push the tag later today. Did we already move those fixes to master? If not, those should be merged.

[MichaelChirico]

Yes, will push the tag later today. Did we already move those fixes to master? If not, those should be merged.

yes they're included already:

e24a66a

74db860

[TysonStanley]

The release is tagged so 1.15.2 is complete. Will be watching the tests this week to see if anything new pops up