Skip to content

Wrong documentation in weak OT solver #404

Closed

Description

@jvlindheim

Thanks for the addition of the weak OT solver this year!

I just wanted to comment on the docstring of this function. To my understanding, there is an error in the statement of the problem that is solved: The quadratic losses should be weighted by the source sample weights. Furthermore, there is a Latex error because of a missing space.
Finally, I would add G0 to the list of parameters.

Activity

  1. rflamary commented on Oct 27, 2022

    @rflamary
    Collaborator

    Hello @jvlindheim those arer all good points. Feel free to propose a PR to correct the documentation. This is good timing the weke OT solver has not been released officially yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions