Skip to content

Conversation

@yutingc
Copy link
Contributor

@yutingc yutingc commented May 12, 2015

Will ignore files when comparing change lists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this contain the binplaced locations also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Let me try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it doesn't ignore the binplaced locations. Shall we add a line to ignore those too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. since the binplaced location contains built-binaries and the user does not need to push to github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added binplace location.

@raghushantha
Copy link
Member

Sign-off..

yutingc added a commit that referenced this pull request May 12, 2015
@yutingc yutingc merged commit 83f214a into master May 12, 2015
@vors vors removed the in progress label May 12, 2015
@yutingc
Copy link
Contributor Author

yutingc commented May 12, 2015

Thanks!

@yutingc yutingc deleted the gitignore branch May 12, 2015 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants