Repository navigation
Conversation
clr182
requested review from
Gilbert09 and
andrewjmcgehee
and removed request for
a team
December 30, 2025 12:09
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="products/data_warehouse/backend/api/data_warehouse.py">
<violation number="1" location="products/data_warehouse/backend/api/data_warehouse.py:607">
P2: Silent exception handling with `except Exception: pass` hides errors and makes debugging difficult. Consider logging the exception at minimum.</violation>
<violation number="2" location="products/data_warehouse/backend/api/data_warehouse.py:653">
P2: Sorting logic puts `None` values first, not last as the comment states. With `reverse=True`, tuples where `failed_at is None` evaluate to `(True, "")` which sorts before `(False, "date")` in descending order.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
| } | ||
| ) | ||
| except Exception: | ||
| pass |
Contributor
There was a problem hiding this comment.
question: why are we not logging this exception?
Member
Author
There was a problem hiding this comment.
updating this to log a warning, same as transformations
| ) | ||
|
|
||
| # Get failed batch exports | ||
| failed_batch_exports = BatchExport.objects.filter( |
Contributor
There was a problem hiding this comment.
should we limit for the latest runs instead of loading all of them? (thinking about performance in the long term)
Member
Author
There was a problem hiding this comment.
^ that's a much better idea
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="products/data_warehouse/backend/api/data_warehouse.py">
<violation number="1" location="products/data_warehouse/backend/api/data_warehouse.py:659">
P3: Consider using structured logging kwargs instead of f-string for better log searchability and aggregation. With f-strings, each unique `destination.id` creates a unique message, making it harder to query logs by destination ID.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
estefaniarabadan
approved these changes
Dec 30, 2025
Contributor
|
overall looks good, the cubic-dev comment on the sorting situation looks legit, but that's it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Partially raised by this user: https://posthoghelp.zendesk.com/agent/tickets/46012 (moved to PostHog: https://us.posthog.com/project/2/support/tickets/48024)
Right now we don't have a great way of alerting customers of potential data pipeline issues. ideally this would be done by alerts in the future e.g. slack or email.
Changes
This returns failed/disabled data pipeline items and failed mat views and presents them in a new side panel. Side panel item is visible only when there is an issue. It lists all failed items with error message and a link to the item.
How did you test this code?
Tested locally and added some dummy data, removed for PR.
Publish to changelog?
No