Keep track of invalid measurements#67
Merged
dmuino merged 1 commit intoNetflix:masterfrom Mar 11, 2020
Merged
Conversation
Show the unique warnings we get from the server when we post measurements. Additionally standardize on the Ids used by spectator-js: `spectator.measurements id=sent|dropped error=validation|http-error|other` for the counters that track the number of measurements sent successfully versus the ones that were dropped for various reasons.
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 84.18% 82.93% -1.26%
==========================================
Files 38 38
Lines 974 996 +22
==========================================
+ Hits 820 826 +6
- Misses 154 170 +16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the unique warnings we get from the server when we post
measurements. Additionally standardize on the Ids used by spectator-js:
spectator.measurements id=sent|dropped error=validation|http-error|otherfor the counters that track the number of measurements sent successfully
versus the ones that were dropped for various reasons.