Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell us what this change does. If you're fixing a bug, please mention
the github issue number.
Please ensure you are submitting from a unique branch in your repository to
mainupstream.Verification
List the steps needed to make sure this thing works
{ "huggingface": { "torch_type": "float32" } }garak -t <target_type> -n <model_name>python -m pytest tests/If you are opening a PR for a new plugin that targets a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us as much detail as possible.
Specific Hardware Examples:
cuda/mps( Please notcudaviaROCmif related )Complex Software Examples:
Summary
Fixes #1499.
The
buffs.paraphrase.Fastbuff currently relies on the externaltransformers-community/group-beam-searchcustom generation implementation andtrust_remote_code. Newer Transformers versions provide the required group beam search functionality natively, making the custom generation dependency unnecessary and causing compatibility issues.Changes
custom_generatedependency fromFast.trust_remote_coderequirement and argument.num_beamsnum_beam_groupsnum_return_sequencesdiversity_penaltyDuplicate-work check
I checked the open garak PRs around paraphrase/custom generation and did not find an open PR addressing this specific compatibility fix.
Verification
Focused test:
python -m pytest tests/buffs/test_buffs.py -k "fast or native_group_beam_search"