Shriya/tp overlap patch #205
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrendx
reviewed
May 9, 2023
Contributor
Author
ptrendx
reviewed
May 9, 2023
ptrendx
reviewed
May 9, 2023
ksivaman
reviewed
May 9, 2023
timmoon10
requested changes
May 9, 2023
Collaborator
There was a problem hiding this comment.
If I understand correctly, the only functional change is to change some memory accesses to use atomicAdd_system. We also add some more information to an error message, which requires plumbing in layer_name throughout the whole PyTorch infrastructure. If this debugging info is not essential, I feel the extra messiness is not worth it. If it is absolutely needed, then at the very least we should change layer_name to something less awkward and confusing, maybe ub_layer_id or ub_layer_label.
b26cdba to
aaced36
Compare
Contributor
Author
|
Agreed, removed the logging commit from this PR |
ptrendx
approved these changes
May 9, 2023
Member
|
@ShriyaPalsamudram please sign your commit. |
Signed-off-by: Sangkug Lym <[email protected]>
df43bf0 to
d178cea
Compare
ksivaman
approved these changes
May 10, 2023
ptrendx
pushed a commit
that referenced
this pull request
May 10, 2023
userbuffer pushsend/recv fix with atomicAdd_system Signed-off-by: Sangkug Lym <[email protected]> Co-authored-by: Sangkug Lym <[email protected]>
nzmora-nvidia
pushed a commit
to nzmora-nvidia/TransformerEngine
that referenced
this pull request
May 10, 2023
userbuffer pushsend/recv fix with atomicAdd_system Signed-off-by: Sangkug Lym <[email protected]> Co-authored-by: Sangkug Lym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming @erhoo82's branch: tp_overlap_patch