Page blob device - #147
Merged
Badrish Chandramouli (badrishc) merged 47 commits intoJul 23, 2019
Merged
Conversation
|
|
Contributor
Author
|
Testing of this PR also hindered by #148, although not completely blocked, |
… tests to also run for AzurePageBlobDevice.
Merged
Collaborator
|
I think this device should be in its own project instead of within FASTER.core. Then, users can opt in to the feature, otherwise they would have to take a NuGet dependency on the Azure related NuGet just to run FASTER core. Project and namespace could be named FASTER.devices.AzurePageBlobDevice. |
Badrish Chandramouli (badrishc)
requested a review
from Peter Freiling (peterfreiling-zz)
July 12, 2019 19:32
Contributor
Author
|
Badrish Chandramouli (@badrishc) I had to add a lot more code to deal with the race around Create. Will squash all these commits when merging. |
Badrish Chandramouli (badrishc)
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements an
IDevicebacked by Azure page blob storage.Still TODO:
So far this PR is tested by replacingDevices::CreateLogDevicewith one that returnsAzurePageBlobStorageinstead ofLocalStorageDevice. All tests pass, but performance is an order of magnitude slower. So probably should not check those in.For unit tests, we will want to use an emulator. Need to figure out how to set that up with Azure pipelines.Unit test performance is visibly worse than local disk when using emulator, and even worse than that when using a real storage account. While it is expected, I need to run some more benchmarks to see if the slowdown is reasonable.Fix #139