Skip to content

Fix wait_on_start type-instance condition checking to use fail_time w… - #1474

Merged
jlnav merged 3 commits into
developfrom
bugfix/wait_on_start_int
Dec 3, 2024
Merged

jlnav merged 3 commits into
developfrom
bugfix/wait_on_start_int

Conversation

@jlnav

@jlnav jlnav commented Nov 21, 2024

Copy link
Copy Markdown
Member

Addresses #1468.

Basically True and False got interpreted as 0 and 1, valid integers for wait_on_start,
meaning the Executor.fail_time attribute never got used.

Now we use that attribute if we actually got True. Any other integer >1 means we wait for that time. False being 0 should simply mean we don't wait.

Thanks @cchall!

@codecov

codecov Bot commented Nov 21, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (09c6f52) to head (065134f).
Report is 111 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1474      +/-   ##
===========================================
- Coverage    90.93%   90.93%   -0.01%     
===========================================
  Files           76       76              
  Lines         7679     7678       -1     
  Branches      1139     1139              
===========================================
- Hits          6983     6982       -1     
  Misses         534      534              
  Partials       162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav
jlnav requested review from jmlarson1 and shuds13 November 22, 2024 16:07
@shuds13

shuds13 commented Nov 25, 2024

Copy link
Copy Markdown
Member

This used to be a boolean, what is the use case for waiting N seconds?

@jlnav

jlnav commented Nov 25, 2024

Copy link
Copy Markdown
Member Author

I don't exactly remember; I introduced the change in #1226.

Based on grepping through all of github and known frameworks that use libE, I can probably change the option back to boolean only.

@jlnav
jlnav merged commit 2480a86 into develop Dec 3, 2024
@jlnav
jlnav deleted the bugfix/wait_on_start_int branch December 4, 2024 16:47
@shuds13 shuds13 mentioned this pull request Dec 6, 2024
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants