Repository navigation
Fix wait_on_start type-instance condition checking to use fail_time w… - #1474
Merged
Merged
Conversation
…hen wait_on_start is actually boolean
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1474 +/- ##
===========================================
- Coverage 90.93% 90.93% -0.01%
===========================================
Files 76 76
Lines 7679 7678 -1
Branches 1139 1139
===========================================
- Hits 6983 6982 -1
Misses 534 534
Partials 162 162 ☔ View full report in Codecov by Sentry. |
Member
|
This used to be a boolean, what is the use case for waiting N seconds? |
Member
Author
|
I don't exactly remember; I introduced the change in #1226. Based on grepping through all of github and known frameworks that use libE, I can probably change the option back to boolean only. |
shuds13
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1468.
Basically
TrueandFalsegot interpreted as0and1, valid integers forwait_on_start,meaning the
Executor.fail_timeattribute never got used.Now we use that attribute if we actually got
True. Any other integer >1 means we wait for that time.Falsebeing0should simply mean we don't wait.Thanks @cchall!