Repository navigation
Fix zero GPU case when GPUs assigned to worker - #1398
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1398 +/- ##
===========================================
+ Coverage 76.51% 76.61% +0.09%
===========================================
Files 88 88
Lines 8019 8055 +36
Branches 1435 1442 +7
===========================================
+ Hits 6136 6171 +35
- Misses 1665 1666 +1
Partials 218 218 ☔ View full report in Codecov by Sentry. |
shuds13
requested review from
jlnav and
jmlarson1
and removed request for
jlnav
August 12, 2024 20:02
jlnav
approved these changes
Aug 12, 2024
|
I tested this PR with a scaled-down version of my setup, and it fixed the issue. Thanks a bunch, @shuds13! 🚀 |
jmlarson1
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GPUs have been assigned to a worker, and num_gpus=0 is sent, it was assigning all available GPUs.
This PR also changes some scenarios where resources are under-utilized for a submit, such that the given configuration will be fit to the minimum nodes required.
E.g., if a worker has been assigned 2 nodes but gets a run configuration of num_procs=2 and num_gpus=2, and this can be accommodated on one node, then only one node will be used, rather than splitting over two.