Skip to content

MPIExecutor wait_time always set by wait_on_start #1468

Closed

Description

@cchall

The change to the wait_on_start feature of the MPIExecutor in 1ba9f57 to change it from bool to either bool or int looks like it results in MPIExecutor.fail_time always being ignored.

In the case wait_on_start=True it looks like MPIExecutor.fail_time should be used to set the wait time. However, the check

wait_time = wait_on_start if isinstance(wait_on_start, int) else self.fail_time

always passes with the first condition because bool is a subclass of int. This can cause failed simulations to not be caught if fail_time > 1 was needed.

Activity

  1. moved this to In review/testing in libE Kanbanon Dec 10, 2024
  2. jlnav commented on Dec 10, 2024

    @jlnav
    Member

    Thanks Chris for the bug report! The corresponding fix should appear in our upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    • Status
      In review/testing

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions