Skip to content

Improve setting of is_manager and nworkers in ensemble class #1331

Closed

Description

@shuds13

When parse_args is not used, ensemble class does not set nworkers or is_manager.

This is somewhat non-trivial due to the different order in which things can be set. However, it is particularly problematic that if ensemble.is_manager does not work at the end of a script.

I have looked at setting these in the libE_specs setter function when they are set in new_specs, but suprisingly, this seems to contain default values in addition to those explicitly specified. I don't want to assume a default MPI here if it is not set, so maybe we need to duplicate what we do in the validators in default_comms.

Activity

  1. self-assigned this
    on Jul 16, 2024
  2. shuds13 commented on Jul 16, 2024

    @shuds13
    MemberAuthor

    Fixed by #1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions