Viewer - No 3D image on playback #9051
Conversation
common/viewer.cpp
Outdated
| s.second.profile.stream_type() == RS2_STREAM_FISHEYE)) | ||
| { | ||
| auto profile_unique_id = s.second.profile.unique_id(); | ||
| bool profile_found = streams_origin.find(profile_unique_id) != streams_origin.end(); |
There was a problem hiding this comment.
If we're doing the find here, why aren't we keeping the iterator so we don't have to find it again (line 450 and 455)?
There was a problem hiding this comment.
We can do it, but lets decide widely for all the usage first.
I will change it accordingly
There was a problem hiding this comment.
I personally don't like it when searches happen twice. I think performance is quality. It can be done while keeping the code readable. Short code is not always readable.
maloel
left a comment
There was a problem hiding this comment.
My only issue is that we do all the searches twice...
We need to decide performance over shrinked code, it's used this way all over the viewer.
What do you think? |
|
There's still an extra search in there... but OK :) |
point cloud image are ignored during playback / DQT 3D streaming
This fix allow pointcloud frames to be uploaded to the rendering window
Tracked on [RS5-11334]