remove emitter-on-off support from b5b #9017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
suggested changes
May 19, 2021
src/ds5/ds5-device.cpp
Outdated
| // Alternating laser pattern should be set and query in a different way according to the firmware version | ||
| bool is_fw_version_using_id = (_fw_version >= firmware_version("5.12.8.100")); | ||
| if ((_fw_version >= firmware_version("5.11.3.0")) && ((_device_capabilities & mask) == mask)) | ||
| if (_pid != ds::RS405_PID) // D405 does not have emitter |
Contributor
There was a problem hiding this comment.
Use dynamic discovery (line 901) and act according to CAP_ACTIVE_PROJECTOR.
That capability must be off for 0x0B5B
ev-mp
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: DSO-17048