Skip to content

fix software device in Python wrapper #9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ev-mp merged 1 commit into from
Aug 15, 2021
Merged

fix software device in Python wrapper #9011

ev-mp merged 1 commit into from
Aug 15, 2021

Conversation

@mengyui
Copy link

@mengyui mengyui commented May 12, 2021

fix matcher for Python wrapper
fix software device in Python wrapper

ev-mp
ev-mp suggested changes May 23, 2021
View reviewed changes
Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mengyui , thank you for the contribution.
The new API must be also propagated to C# and Java.

@ev-mp
Copy link
Contributor

ev-mp commented Jun 3, 2021

@mengyui , any update?

@mengyui mengyui force-pushed the python-software-device branch from 532128f to 045beb7 Compare August 6, 2021 15:42
@mengyui
Copy link
Author

mengyui commented Aug 6, 2021

@ev-mp Sorry for late. I'm missing the notification.
This PR is bug fix, not a new feature.
and all the functions about convert enum type to string type are not used as (wrapper) API.

@maloel
Copy link
Contributor

maloel commented Aug 12, 2021

@mengyui Thanks for the fixes!
As it turns out a lot of these changes are the same as what I'm currently working on that was scheduled to be released in version 2.50. Did you also have code that uses the software device from Python? It'd be interesting to see...

@ev-mp Note that DIC and DIC_C aren't really supported and will throw. Let's discuss if we want them in there -- I did something a little different.

@maloel maloel requested a review from ev-mp August 15, 2021 09:58
ev-mp
ev-mp approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ev-mp ev-mp merged commit b3b2ef0 into realsenseai:development Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ev-mp ev-mp ev-mp approved these changes

@maloel maloel maloel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengyui @ev-mp @maloel