Skip to content

Conversation

@remibettan
Copy link
Contributor

Tracked by: DSO-14036

Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel
Copy link
Contributor

maloel commented Apr 29, 2021

Where's the Unit-test?!!?!?!?!
¯\_(ツ)_/¯
🥰

@remibettan
Copy link
Contributor Author

Where's the Unit-test?!!?!?!?!
¯\_(ツ)_/¯
🥰

I don't think it is needed here - let's talk about it

@remibettan remibettan force-pushed the l500-color-metadata-display-negative-values branch 2 times, most recently from ef99276 to 4ba8fc9 Compare May 9, 2021 05:21
Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I put minor remarks

@remibettan remibettan requested a review from ev-mp May 9, 2021 19:24
@remibettan remibettan force-pushed the l500-color-metadata-display-negative-values branch from 82a8d84 to 2130364 Compare May 10, 2021 13:43
Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ev-mp ev-mp merged commit 6a595d3 into realsenseai:development May 10, 2021
@remibettan remibettan deleted the l500-color-metadata-display-negative-values branch July 29, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants