Skip to content

Conversation

@doronhi
Copy link
Contributor

@doronhi doronhi commented Apr 21, 2021

Add test for memory issue using valgrind and a fix.

To test the memory issue:

valgrind --leak-check=yes --show-leak-kinds=all --track-origins=yes ./unit-tests/build/utilities/memory/test-sensor-option/test-utilities-memory-sensor-option 2>&1 | grep depends

If everything is ok should print nothing.
Tracked in DSO-16885

Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add DSO id

float option_value(depth_sens.get_option(RS2_OPTION_ENABLE_AUTO_EXPOSURE));

std::cout << "Declare: BOOL::" << option_value << std::endl;
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@doronhi doronhi force-pushed the memory_leak_test-sensor-option branch from 80a8eef to 14f5670 Compare May 13, 2021 12:07
Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 24a02cb into realsenseai:development May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants