Ensure custom deleter is called by passing non-null pointer in ctor #6161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @anmelleSlamcore |
dorodnic
approved these changes
Mar 30, 2020
ev-mp
approved these changes
Mar 30, 2020
Contributor
ev-mp
left a comment
There was a problem hiding this comment.
Hello @anmelleSlamcore ,
Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom deleters for
std::unique_ptrare not invoked if the owned pointer is null.Therefore, the function setup to
acquire_metadataat the end of the scope will never fire.Solution is to pass a valid pointer, and let the custom deleter delete the object.