-
Notifications
You must be signed in to change notification settings - Fork 5k
Replace libtm with direct communication with T265 #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is currently a draft, it is not ready for merging but is provided here to allow for wider visibility / testing as it is being completed. |
6691d10 to
3536bc8
Compare
36e9ec3 to
d5a4db5
Compare
| */ | ||
| int rs2_loopback_is_enabled(const rs2_device* device, rs2_error** error); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep the APIs, to not break any existing code.
At runtime these APIs check if controllers are available and on the T265 will always return false
2a30775 to
b8368f2
Compare
b8368f2 to
60c8885
Compare
dde1fcd to
1a7f582
Compare
1a7f582 to
b2d1fbd
Compare
I'm all the time running into merge conflicts when I try to pull a new commit to this PR. My usual answer is to do all from scratch (clone repo, checkout development, apply patch), but would there be a smarter solution? |
|
Glad to hear, @neilyoung. Thanks for testing. |
|
Yesterday I installed from scratch on a brand new Raspbian Buster, used development branch and #5213, compiled and built everything from scratch. Works like a charm. |
ev-mp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bfulkers-i ,this is a significant contribution and major accomplishment.
Thanks you very much for your work!
This PR removes libtm completely and makes T265 a first class driver in librealsense. In more detail, it: