Skip to content

split processing block to processing_block(invoke) and filter(process) #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorodnic merged 1 commit into from
Nov 21, 2018
Merged

split processing block to processing_block(invoke) and filter(process) #2757

dorodnic merged 1 commit into from
Nov 21, 2018

Conversation

@matkatz
Copy link
Contributor

@matkatz matkatz commented Nov 21, 2018

  • remove "process" API from processing_block class
  • add "filter" class which implement "process"

dorodnic
dorodnic approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@dorodnic dorodnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorodnic dorodnic merged commit 9580201 into realsenseai:development Nov 21, 2018
@dorodnic dorodnic mentioned this pull request Nov 21, 2018
Merged
@matkatz matkatz deleted the filter_api branch December 23, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dorodnic dorodnic dorodnic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matkatz @dorodnic