fix infinite loop at the end even if depth = 0 #14324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an infinite loop bug in the depth pixel projection function that occurred when the loop reached the end pixel with a depth value of 0. The fix adds a boundary check to break out of the loop when reaching the end pixel, preventing the infinite loop condition.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@wsmlby thank you for contributing. Can you share some details about your use case? |
OhadMeir
reviewed
Oct 8, 2025
OhadMeir
approved these changes
Oct 9, 2025
Contributor
Author
|
We use realsense depth cam in warehouses @ ~thousands units. We occasionally run into a stuck process because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR: #14295
Didn't fix the issue when it hit depth==0 and continued.